Dan Kenigsberg has posted comments on this change.
Change subject: hsm: expose the sendExtendMsg command
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_cli/vdsClient.py
Line 2060: ('<sdUUID> <spUUID> <imgUUID> <volUUID> '
Line 2061: '<new disk size>',
Line 2062: 'Extend volume (SAN only)'
Line 2063: )),
Line 2064: 'sendExtendMsg': (serv.sendExtendMsg,
how about naming this as a test-only verb?
Otherwise, alitke would require this to be added to the schema.
Hmm, maybe it should be properly declared, and declared as "undocumented, test
only"?
Line 2065: ('<sdUUID> <spUUID> <imgUUID> <volUUID> '
Line 2066: '<new disk size>',
Line 2067: 'Send extend volume request to the SPM (SAN
only)'
Line 2068: )),
--
To view, visit http://gerrit.ovirt.org/8286
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2099c2dee0bfdb172036edee389cca259f13ce0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
