Dan Kenigsberg has posted comments on this change. Change subject: vdsm-restore-net-config: wait for links with netlink monitor ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/53968/3/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 319: available_bonds[bond]['nics'] = available_bond_nics Line 320: return available_bonds Line 321: Line 322: Line 323: def _wait_for_all_devices_up(links): > I think you need to continue checking 'mon' in a loop until either all link I vote for simplicity. This code runs only once during boot. No need to optimize it with test-acquire-test. Line 324: try: Line 325: with monitor.Monitor(groups=('link',), timeout=5) as mon: Line 326: down_links = _get_links_with_state_down(links) Line 327: logging.debug("waiting for %s to be up.", down_links) -- To view, visit https://gerrit.ovirt.org/53968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c45430925a55bb54995b91a061bc15affe15763 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
