Douglas Schilling Landgraf has uploaded a new change for review. Change subject: setNetworking(): set bridge status ......................................................................
setNetworking(): set bridge status Currently, if the bridge for some reason is not created, users are informed with a warning message and bootstrap continues, the host is rebooted and Engine will report the node as Non Responsive. This patch will stop bootstrap as soon as any error occurs adding brigde and will show to users the an error message like: "Failed to install Host X.Y.Z. Step: SetNetworking: Details: addNetwork error trying to add mangament bridge." Change-Id: I9a24cc1ebd92669faeab8d189aac6ab46a762130 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=840300 Signed-off-by: Douglas Schilling Landgraf <[email protected]> --- M vds_bootstrap/vds_bootstrap.py 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/8345/1 diff --git a/vds_bootstrap/vds_bootstrap.py b/vds_bootstrap/vds_bootstrap.py index 0caa5e9..601b00d 100755 --- a/vds_bootstrap/vds_bootstrap.py +++ b/vds_bootstrap/vds_bootstrap.py @@ -765,9 +765,7 @@ def setNetworking(self, iurl): """ Create management bridge. - This class will try to create a management bridge named "rehvm". Class - always succeeds to allow network configuration from managment server - even in case this class will fail to set the management bridge. + This class will try to create a management bridge. Note: expected input format: http://www.redhat.com/a/b/c or: ftp://10.0.0.23/d/e/f """ self.status = "OK" @@ -786,10 +784,11 @@ self.message = "Failed to parse manager URL!" self.status = "FAIL" logging.error(self.message) - #Do not set rc to allow changes from rhev-m. + #Do not set rc to allow changes from Engine else: if not self._addNetwork(url, port): - self.status = "WARN" + self.status = "FAIL" + self.rc = False self._xmlOutput('SetNetworking', self.status, None, None, self.message) return self.rc -- To view, visit http://gerrit.ovirt.org/8345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9a24cc1ebd92669faeab8d189aac6ab46a762130 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
