Piotr Kliczewski has posted comments on this change. Change subject: bridge: obtain method ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/53472/7/tests/stompTests.py File tests/stompTests.py: Line 55: def unregister_server_address(self): Line 56: self.server_address = None Line 57: Line 58: def dispatch(self, method): Line 59: return getattr(self, method) > This will raise AttributeError, while the real code raise json rpc error ab Good point, will align this code to work as real code. Line 60: Line 61: Line 62: @expandPermutations Line 63: class StompTests(TestCaseBase): -- To view, visit https://gerrit.ovirt.org/53472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b6cb53d8e42335510e34dfe372c1c21b80ac219 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
