Nir Soffer has posted comments on this change. Change subject: move alignmentScan.py to lib ......................................................................
Patch Set 7: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/53758/7/lib/vdsm/alignmentScan.py File lib/vdsm/alignmentScan.py: Line 21: Line 22: Line 23: from collections import namedtuple Line 24: from vdsm.utils import CommandPath Line 25: from vdsm.commands import execCmd Please keep using misc.execCmd - this changes the logging and may break our debugging tools depending on vdsm log. Looks like storage.misc must move first to lib - and alignmentScan should move into lib/vdsm/storage - this is not common infrastructure. Line 26: Line 27: ScanOutput = namedtuple( Line 28: 'ScanOutput', Line 29: ['partitionName', 'partitionStartBytes', 'partitionAlignment', -- To view, visit https://gerrit.ovirt.org/53758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0537393da342507c9e64e9d71656cfc69bbe15e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
