Nir Soffer has posted comments on this change. Change subject: gluster: Don't fail connect server when getting volume info ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/53785/10/tests/storageServerTests.py File tests/storageServerTests.py: Line 263: self.assertEquals(gluster.options, "") Line 264: Line 265: Line 266: @expandPermutations Line 267: class GlusterFSNotAccessibleConnectionTests(VdsmTestCase): These tests not test anything, because you did not monkeypatch gluster.cli.exists - the code does not reach the self.info check. Please add: @MonkeyPatch(gluster.cli, 'exists', lambda: True) For both tests. Line 268: Line 269: def glusterVolumeInfo(self, volumeName=None, remoteServer=None): Line 270: raise ge.GlusterCmdExecFailedException() Line 271: -- To view, visit https://gerrit.ovirt.org/53785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
