Mark Wu has posted comments on this change. Change subject: Update scsi_id options format and add devices to multipath.conf ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) Could you please explain what problem you're trying to fix by this patch? Thanks! .................................................... File vdsm/constants.py.in Line 177: " vendor \"HITACHI\"\n" Line 178: " product \"DF.*\"\n" Line 179: " getuid_callout \"@SCSI_ID_PATH@ --whitelisted " Line 180: "--replace-whitespace --device=/dev/%n\"\n" Line 181: "}\n" It looks you don't add any special configuration for HITACHI DF* storage. Why do you explicitly add it to the devices list? Line 182: "}" .................................................... File vdsm/storage/multipath.py Line 48: MPATH_CONF = "/etc/multipath.conf" Line 49: Line 50: OLD_TAGS = ["# RHAT REVISION 0.2", "# RHEV REVISION 0.3", Line 51: "# RHEV REVISION 0.4", "# RHEV REVISION 0.5", Line 52: "# RHEV REVISION 0.6"] It seems you also need add "# RHEV REVISION 0.7" OLD_TAGS Line 53: MPATH_CONF_TAG = "# RHEV REVISION 0.8" Line 54: MPATH_CONF_PRIVATE_TAG = "# RHEV PRIVATE" Line 55: MPATH_CONF_TEMPLATE = MPATH_CONF_TAG + constants.STRG_MPATH_CONF Line 56: -- To view, visit http://gerrit.ovirt.org/8363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I088ff2d4ff600ec9c1e784a43f3336e36ceb717d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
