Martin Polednik has posted comments on this change. Change subject: faqemu: refactor and update ......................................................................
Patch Set 24: (2 comments) https://gerrit.ovirt.org/#/c/46961/24/vdsm_hooks/faqemu/before_vm_start.py File vdsm_hooks/faqemu/before_vm_start.py: Line 172: 'model')[0].getAttribute('ram') is None) Line 173: Line 174: Line 175: @workaround() Line 176: def _graphics_remove_passwd(domxml): > could you please remind me why is this needed? possibly not needed, let me recheck Line 177: graphics = domxml.getElementsByTagName('graphics')[0] Line 178: graphics.removeAttribute('passwdValidTo') Line 179: Line 180: Line 291: return (not domxml.getElementsByTagName('sound')) Line 292: Line 293: Line 294: @workaround(arch=cpuarch.X86_64, Line 295: target_arch=cpuarch.PPC64LE) > I feel I'm missing something: Since PPC64LE uses pseries machine type, we need something that will work on our host (pc-i440fx is the default for x86_64 now). Please note that this is *not* emulation. It is starting a VM that presents itself as ppc64le while being x86_64 under the hood. This is because qemu-kvm-rhev does NOT support emulation. Line 296: def _os_set_machine_type_i440fx(domxml): Line 297: ostag = domxml.getElementsByTagName('os')[0] Line 298: typetag = ostag.getElementsByTagName('type')[0] Line 299: typetag.setAttribute('machine', 'pc-i440fx-rhel7.1.0') -- To view, visit https://gerrit.ovirt.org/46961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb82b492e33d507e198901f7ecc77531b0680711 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
