Francesco Romani has submitted this change and it was merged. Change subject: vmstats: from EAFP to LBYL ......................................................................
vmstats: from EAFP to LBYL libvirt bulk stats' API allows to return partial result. Hence, seems better to Look Before You Leap in this flow, instead of thinking that is Easier (to) Ask Forgiveness (than) Permission. As nice side effect, this patch removes spam from the logs. Change-Id: I7383ff62e8c7e7923567b6d04942bb1e92aab84a Bug-Url: https://bugzilla.redhat.com/1299480 Backport-To: 3.6 Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/53613 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <dan...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/54001 Reviewed-by: Martin Polednik <mpoled...@redhat.com> --- M vdsm/virt/vmstats.py 1 file changed, 13 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Verified; Looks good to me, approved Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7383ff62e8c7e7923567b6d04942bb1e92aab84a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches