Freddy Rolland has posted comments on this change. Change subject: storage: Move constants module to site-packages ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/54404/1/vdsm/storage/fileSD.py File vdsm/storage/fileSD.py: Line 34: import outOfProcess as oop Line 35: from remoteFileHandler import Timeout Line 36: from persistentDict import PersistentDict, DictValidator Line 37: from vdsm import constants Line 38: from vdsm.utils import stripNewLines > here Done Line 39: from vdsm import supervdsm Line 40: import mount Line 41: Line 42: from vdsm.storage.constants import LEASE_FILEEXT https://gerrit.ovirt.org/#/c/54404/1/vdsm/storage/fileVolume.py File vdsm/storage/fileVolume.py: Line 24: Line 25: import storage_exception as se Line 26: from vdsm import exception Line 27: from vdsm import qemuimg Line 28: from vdsm.commands import grepCmd > here Done Line 29: from sdc import sdCache Line 30: import outOfProcess as oop Line 31: import volume Line 32: import image https://gerrit.ovirt.org/#/c/54404/1/vdsm/storage/misc.py File vdsm/storage/misc.py: Line 49: from vdsm import commands Line 50: from vdsm import concurrent Line 51: from vdsm import constants Line 52: from vdsm import logUtils Line 53: from vdsm import utils > move it here Done Line 54: import storage_exception as se Line 55: Line 56: from vdsm.storage.constants import SECTOR_SIZE Line 57: https://gerrit.ovirt.org/#/c/54404/1/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 32: from imageRepository.formatConverter import DefaultFormatConverter Line 33: Line 34: from vdsm import concurrent Line 35: from vdsm import constants Line 36: from vdsm.panic import panic > move it here Done Line 37: import storage_mailbox Line 38: import blockSD Line 39: import fileSD Line 40: import sd -- To view, visit https://gerrit.ovirt.org/54404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I413e0b54de0d06f7eee3ecb4094f0281bb77dc51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
