Milan Zamazal has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/53677/7/tests/devices/data/testComplexVm.xml File tests/devices/data/testComplexVm.xml: Line 142: <backend model='random'>/dev/random</backend> Line 143: <alias name='rng1'/> Line 144: <address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/> Line 145: </rng> Line 146: <disk device="cdrom" snapshot="no" type="file"> > Could you please remind me why this is needed? This piece of XML is needed to get the moved code at least partially covered by the tests. If it is not present the top loop in Drive.update_device_info just skips. Line 147: <address bus="1" controller="0" target="0" type="drive" unit="0"/> Line 148: <source file="" startupPolicy="optional"/> Line 149: <target bus="ide" dev="hdc"/> Line 150: <readonly/> -- To view, visit https://gerrit.ovirt.org/53677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6b372f86b82da7422727f3d084b9afc5505a289 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
