Edward Haas has posted comments on this change.

Change subject: net: api: use logger as modules' variable
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/54350/3/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

Line 46: network_legacy_switch
Seems too long for the log.
What about 'net_legacy_sw' or 'legacy_switch'?


-- 
To view, visit https://gerrit.ovirt.org/54350
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia05f237dedcf932028169e4d8fd336b42dbe5125
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to