Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-reg: use web server CA extracted from SSL handshake
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 1589:
Line 1590: """
Line 1591: try:
Line 1592: chain = getChainFromSSL((IP, int(port)))
Line 1593: if not chain:
swallowing exceptions has some (false) logic, when they are used by a code that
(falsely) assumed no exceptions, an that you do not want to re-check.
here, it is a little helper function, that might have been declated _private.
so here I do not see any point in catching all exceptions.
But I can take this, trusting you that the rewrite is next in line.
Line 1594: raise Exception('No chain')
Line 1595:
Line 1596: ca = chain[-1]
Line 1597: _, _, engineWebCACert = certPaths('')
--
To view, visit http://gerrit.ovirt.org/8386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8727a167de19ac66712309868654ae00c9bf4d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
