Martin Polednik has posted comments on this change. Change subject: machinetype: split and slightly refactor cpu_models function ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54301/1/lib/vdsm/machinetype.py File lib/vdsm/machinetype.py: Line 112: arch = 'ppc64' Line 113: Line 114: arch_element = None Line 115: Line 116: arch_elements = cpu_map.findall('arch') > we probably don't need this temporary but keeping it avoids needing 2 findalls Line 117: Line 118: if arch_elements: Line 119: for element in arch_elements: Line 120: if element.get('name') == arch: -- To view, visit https://gerrit.ovirt.org/54301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I264209f94ef7140e27c534f1df408c7a3a17bbbf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches