Milan Zamazal has posted comments on this change. Change subject: virt: New method Vm.get_devices ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/54090/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5070: def getNicDevices(self): Line 5071: return self._devices[hwclass.NIC] Line 5072: Line 5073: def get_devices(self, hw_class): Line 5074: return self._devices[hw_class] > fine as long as we make sure we pass a copy of the data, to skip future hea Hm, good note. We need to modify the returned object in update_*_info methods, so copying doesn't work here. Perhaps we shouldn't introduce this method and we should explicitly pass the device object to update_*_info methods instead. Line 5075: Line 5076: def getBalloonDevicesConf(self): Line 5077: for dev in self.conf['devices']: Line 5078: if dev['type'] == hwclass.BALLOON: -- To view, visit https://gerrit.ovirt.org/54090 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a7c32806501df8672718c588b2f62087ff4e085 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
