Yaniv Bronhaim has posted comments on this change. Change subject: stomp: message tracking do not clean properly ......................................................................
Patch Set 5: Code-Review+1 (2 comments) acking it, but check my comments and decide if you want to change. https://gerrit.ovirt.org/#/c/48616/5/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 321 Line 322 Line 323 Line 324 Line 325 the change could be only to replace "id" with resp.get("id") Line 319: Sends message to all subscribes that subscribed to destination. Line 320: """ Line 321: def send(self, message, destination=stomp.LEGACY_SUBSCRIPTION_ID_RESPONSE): Line 322: resp = json.loads(message) Line 323: response_id = resp.get("id") don't you prefer to put it under the try? Line 324: Line 325: try: Line 326: destination = self._req_dest[response_id] Line 327: del self._req_dest[response_id] -- To view, visit https://gerrit.ovirt.org/48616 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2ca7c7589fea2d7ad5a477123b14df17924fda0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
