Milan Zamazal has uploaded a new change for review. Change subject: virt: Use PEP8 identifiers in vmxml.device_address ......................................................................
virt: Use PEP8 identifiers in vmxml.device_address This is a trivial change just renaming two local variables. Change-Id: I75ec0bcef132bd8b5bd40bb5f4859578014e2728 Signed-off-by: Milan Zamazal <mzama...@redhat.com> --- M vdsm/virt/vmxml.py 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/54511/1 diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py index 8e65d3a..8f2a812 100644 --- a/vdsm/virt/vmxml.py +++ b/vdsm/virt/vmxml.py @@ -63,19 +63,19 @@ yield deviceXML, alias -def device_address(devXml, index=0): +def device_address(dev_xml, index=0): """ Obtain device's address from libvirt """ address = {} - adrXml = devXml.getElementsByTagName('address')[index] + adr_xml = dev_xml.getElementsByTagName('address')[index] # Parse address to create proper dictionary. # Libvirt device's address definition is: # PCI = {'type':'pci', 'domain':'0x0000', 'bus':'0x00', # 'slot':'0x0c', 'function':'0x0'} # IDE = {'type':'drive', 'controller':'0', 'bus':'0', 'unit':'0'} - for key in adrXml.attributes.keys(): - address[key.strip()] = adrXml.getAttribute(key).strip() + for key in adr_xml.attributes.keys(): + address[key.strip()] = adr_xml.getAttribute(key).strip() return address -- To view, visit https://gerrit.ovirt.org/54511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I75ec0bcef132bd8b5bd40bb5f4859578014e2728 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches