Dan Kenigsberg has posted comments on this change. Change subject: machinetype: document public functions ......................................................................
Patch Set 4: Code-Review-1 (1 comment) silly nit from me, too. https://gerrit.ovirt.org/#/c/54302/4/lib/vdsm/machinetype.py File lib/vdsm/machinetype.py: Line 124: ''' cpu vendor. also, pep8 asks for triple-doublequotes in docstring, not singlequotes -- To view, visit https://gerrit.ovirt.org/54302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e3e4930566d36f1f58e3cf99b84094984cbd334 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches