Edward Haas has posted comments on this change. Change subject: netinfo: dns: more robust parsing of resolv.conf ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54558/2/tests/network/netinfo_test.py File tests/network/netinfo_test.py: Line 63: RESOLV_CONF + '\n' Personally I don't like much the permutation style, it just does not explains well what one intended to test. But if you prefer it this way, perhaps just add another string: RESOLV_CONF = ... RESOLV_CONF_WITH_EMPTY_LINES = RESOLV_CONF + '\n' -- To view, visit https://gerrit.ovirt.org/54558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff7cafb643c9191d9a2f6abbcfec0407e6860e07 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
