Nir Soffer has posted comments on this change. Change subject: tests: refactor manifest_tests fake env setup ......................................................................
Patch Set 2: Code-Review-1 (1 comment) Looks good, one question https://gerrit.ovirt.org/#/c/50273/2/tests/domain_manifest_tests.py File tests/domain_manifest_tests.py: Line 110: with fake_block_env() as env: Line 111: self.assertEquals(512, env.sd_manifest.logBlkSize) Line 112: self.assertEquals(512, env.sd_manifest.phyBlkSize) Line 113: Line 114: def test_overwrite_blocksize(self): Is this new test? can we add it separately? Line 115: metadata = {sd.DMDK_VERSION: 3, Line 116: blockSD.DMDK_LOGBLKSIZE: 2048, Line 117: blockSD.DMDK_PHYBLKSIZE: 1024} Line 118: with fake_block_env() as env: -- To view, visit https://gerrit.ovirt.org/50273 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74b82ffaa34d6df68e1531735cc776e4de23f95c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
