Francesco Romani has posted comments on this change. Change subject: osinfo: use pep8 function names ......................................................................
Patch Set 2: Code-Review+1 (1 comment) possible naming improvement inside. Jenkins fails because of the parent patch, please fix. Besides those two things looks good, hence partial ACK. https://gerrit.ovirt.org/#/c/54543/2/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line 92: _release maybe that's me, but this reminds me more Semaphore.release() than a software release. Maybe _os_release()? -- To view, visit https://gerrit.ovirt.org/54543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11e49e94e7bfbac08ba11da0ffa773925cca3ef0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
