Dan Kenigsberg has posted comments on this change.
Change subject: Fix a bug in the naming convertion of cpu feature 'sse4_x'
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
I suppose that it would be rude to request a unit test for the
feature-conversion code. So I do not. But it would be great if someone had the
capacity to add one.
....................................................
File vdsm/libvirtvm.py
Line 734: features += ['-svm']
Line 735:
Line 736: for feature in features[1:]:
Line 737: # convert Linux name of feature to libvirt
Line 738: if feature[1:6] == 'sse4_':
ouch. the author of this line should be ashamed of himself.
(I am)
I am also surprised that no one has noticed this - exposing sse4 to guests was
supposed to give noticeable performance benefits in several use cases.
Line 739: feature = feature[0] + 'sse4.' + feature[6:]
Line 740:
Line 741: f = self.doc.createElement('feature')
Line 742: if feature[0] == '+':
--
To view, visit http://gerrit.ovirt.org/8413
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia241b09c96fa16441ba9421f61a2f9a417f0d978
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
