Dan Kenigsberg has submitted this change and it was merged. Change subject: stomp: make sure that subscriptions use uniqe id ......................................................................
stomp: make sure that subscriptions use uniqe id There was a bug in the engine that there were two subscriptions with the same id. This issue as a result created fd leak because we were not able to clean the subscription id on connection closed or unsubscribe. Change-Id: I3883bb68134a6e2cc52cf54ce4027122db8150e9 Signed-off-by: pkliczewski <[email protected]> Reviewed-on: https://gerrit.ovirt.org/46656 Continuous-Integration: Jenkins CI Reviewed-by: Yeela Kaplan <[email protected]> Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Yaniv Bronhaim <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/yajsonrpc/stompreactor.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Yeela Kaplan: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46656 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3883bb68134a6e2cc52cf54ce4027122db8150e9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
