Piotr Kliczewski has posted comments on this change. Change subject: stomp: make sure that we are connected before sending data ......................................................................
Patch Set 3: Code-Review-1 (1 comment) I am planning to do more tests. I was not able to reproduce this issue on my env so this patch is only an assumption. -1 for visibility that testing is in progress... https://gerrit.ovirt.org/#/c/54578/3/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 510: def _process_error(self, frame, dispatcher): Line 511: raise StompError(frame) Line 512: Line 513: def send(self, destination, data="", headers=None): Line 514: self._connected.wait(5) > why do you need this wait? and why 5 seconds..? We want to wait for CONNECTED frame if it is not there. Line 515: if not self._connected.is_set(): Line 516: raise NotConnected() Line 517: Line 518: final_headers = {"destination": destination} -- To view, visit https://gerrit.ovirt.org/54578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c914170d2dfa6f8d74c5e712a97b5e34b0fd77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
