Shu Ming has posted comments on this change.
Change subject: libvirtvm: Cast text to string when creating text node
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File tests/utilsTests.py
Line 1: #
Line 2: # Copyright 2012 Red Hat, Inc.
I think we can add IBM copyright here along with Red Hat's.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
....................................................
File vdsm/utils.py
Line 606: return val
Line 607: else:
Line 608: raise ValueError("Refusing to convert type '%s' to unicode" %
\
Line 609: varType)
Line 610:
In the utils test case, "UnicodeDecodeError" exception is expected. It seems
that convertToUnicode() doesn't raise up the exception from unicode().
Line 611: def execCmd(*args, **kwargs):
Line 612: # import only after config as been initialized
Line 613: from storage.misc import execCmd
Line 614: return execCmd(*args, **kwargs)
--
To view, visit http://gerrit.ovirt.org/7832
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id22db83062eaf85645c2d61c83f3f20943918413
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel P. Berrange <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
