Zhou Zheng Sheng has posted comments on this change.

Change subject: Remove duplicate implementation of tobool
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/hooking.py
Line 40: from xml.dom import minidom
Line 41: 
Line 42: from storage.misc import execCmd
Line 43: execCmd  # make pyflakes happy
Line 44: 
Markwu, it's a pyflakes's warning, we can follow what line 43 does to make 
pyflakes happy.

 from vdsm.utils import tobool
 tobool  # make pyflakes happy
Line 45: 
Line 46: def read_domxml():
Line 47:     return minidom.parseString(file(os.environ['_hook_domxml']).read())
Line 48: 


--
To view, visit http://gerrit.ovirt.org/8446
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0d382dabc9df68139070e8ac10f84ba1ca3774b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to