Vinzenz Feenstra has posted comments on this change. Change subject: guest-agent: Fix API version negotiation ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54871/1/lib/vdsm/virt/guestagent.py File lib/vdsm/virt/guestagent.py: Line 201: if commonVersion != self.effectiveApiVersion: Line 202: # Only update if the value changed Line 203: self.log.info("Guest API version changed from %d to %d", Line 204: self.effectiveApiVersion, commonVersion) Line 205: self.effectiveApiVersion = commonVersion > do we have tests for this flow? Worth adding, maybe for a future patch Basically the whole GA is untested right now, so no we don't but that's something I want to work on quite soon Line 206: if commonVersion != _IMPLICIT_API_VERSION_ZERO: Line 207: # Only notify the guest agent if the API was not disabled Line 208: self._forward('api-version', {'apiVersion': commonVersion}) Line 209: -- To view, visit https://gerrit.ovirt.org/54871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5dd8a36395615d4b908a0c88a6bbfee3cab1952 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
