Francesco Romani has uploaded a new change for review.

Change subject: vm: conf: proper locking in status()
......................................................................

vm: conf: proper locking in status()

Change-Id: I397562bb94c8b696a0b34484907e7d489a800878
Bug-Url: https://bugzilla.redhat.com/1318550
Signed-off-by: Francesco Romani <[email protected]>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/54906/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 5db9fbb..956c8c3 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1315,8 +1315,8 @@
             return {'vmId': self.id, 'status': self.lastStatus,
                     'statusTime': self._get_status_time()}
 
-        self.conf['status'] = self.lastStatus
         with self._confLock:
+            self.conf['status'] = self.lastStatus
             # Filter out any internal keys
             status = dict((k, v) for k, v in self.conf.iteritems()
                           if not k.startswith("_"))


-- 
To view, visit https://gerrit.ovirt.org/54906
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I397562bb94c8b696a0b34484907e7d489a800878
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to