Hello Francesco Romani, Martin Polednik, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/54896
to review the following change.
Change subject: guest-agent: Fix API version negotiation
......................................................................
guest-agent: Fix API version negotiation
The guest agent negotation is currently broken due to storing the wrong value
as effectiveAPIVersion.
Currently the reported value by the guest agent is stored, which actually
should not be stored, but the commonVersion value.
Change-Id: Id5dd8a36395615d4b908a0c88a6bbfee3cab1952
Bug-Url: https://bugzilla.redhat.com/1318657
Signed-off-by: Vinzenz Feenstra <vfeen...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54871
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal <mzama...@redhat.com>
Reviewed-by: Martin Polednik <mpoled...@redhat.com>
Reviewed-by: Francesco Romani <from...@redhat.com>
---
M vdsm/virt/guestagent.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/54896/1
diff --git a/vdsm/virt/guestagent.py b/vdsm/virt/guestagent.py
index 57ebc39..1b00ba7 100644
--- a/vdsm/virt/guestagent.py
+++ b/vdsm/virt/guestagent.py
@@ -203,7 +203,7 @@
# Only update if the value changed
self.log.info("Guest API version changed from %d to %d",
self.effectiveApiVersion, commonVersion)
- self.effectiveApiVersion = version
+ self.effectiveApiVersion = commonVersion
if commonVersion != _IMPLICIT_API_VERSION_ZERO:
# Only notify the guest agent if the API was not disabled
self._forward('api-version', {'apiVersion': commonVersion})
--
To view, visit https://gerrit.ovirt.org/54896
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5dd8a36395615d4b908a0c88a6bbfee3cab1952
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
