Nir Soffer has posted comments on this change. Change subject: monitoring: Separate storage health monitoring ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/54757/6/lib/vdsm/storage/check.py File lib/vdsm/storage/check.py: Line 146: Called when dd process has closed stderr. At this point the process may Line 147: be still running. Line 148: """ Line 149: self._reader = None Line 150: self._stats = data.splitlines()[-1] - This breaks when dd fails with no ouput - needs parsing from misc.readspeed. Line 151: rc = self._proc.poll() Line 152: if rc is None: Line 153: self._reaper = Reaper(self._loop, self._proc, self._check_completed) Line 154: return -- To view, visit https://gerrit.ovirt.org/54757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches