Nir Soffer has posted comments on this change. Change subject: tests: Simplify DirectFile tests ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/54678/3/tests/fileUtilTests.py File tests/fileUtilTests.py: Line 30: Line 31: @expandPermutations Line 32: class DirectFileTests(TestCaseBase): Line 33: Line 34: DATA = "a" * 512 + "b" * 512 > Should we use a block size constant instead of a magic number here? Handled in https://gerrit.ovirt.org/54954 Line 35: Line 36: @permutations([[0], [512], [1024], [1024 + 512]]) Line 37: def testRead(self, size): Line 38: with temporaryPath(data=self.DATA) as srcPath, \ -- To view, visit https://gerrit.ovirt.org/54678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic86b0fe22d5d5f1c9252b658ad76a13626de8246 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
