Gal Hammer has posted comments on this change.
Change subject: add "uptime" field to the getStats (getVdsStats in vdsClient)
call
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm/API.py
Line 1102: stats['memShared'] = self._memShared() / Mbytes
Line 1103:
Line 1104: stats['netConfigDirty'] = str(self._cif._netConfigDirty)
Line 1105: stats['generationID'] = self._cif._generationID
Line 1106: stats['uptime'] = time.time() - STARTTIME
I think the whole "math" should be done in the ClientIF and not in the API.
Line 1107: return {'status': doneCode, 'info': stats}
Line 1108:
Line 1109: def setLogLevel(self, level):
Line 1110: """
....................................................
File vdsm_api/vdsmapi-schema.json
Line 1500: 'swapTotal': 'int', 'swapFree': 'int','vmCount': 'int',
Line 1501: 'vmActive': 'int', 'vmMigrating': 'int', 'dateTime':
'str',
Line 1502: 'ksmState': 'bool', 'ksmPages': 'int', 'ksmCpu': 'float',
Line 1503: 'netConfigDirty': 'bool', 'generationID': 'UUID',
Line 1504: 'uptime': 'float'}
I don't like the field name. It is part of the host's stats so I assume this is
the host's uptime and not vdsm's.
vdsmUptime will be more appropriate in my opinion.
Line 1505:
Line 1506: ##
Line 1507: # @Host.getStats:
Line 1508: #
--
To view, visit http://gerrit.ovirt.org/8008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc998117e25faff17c2f3f6d66e2a961fc93e029
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
