Royce Lv has posted comments on this change.
Change subject: vdsm API and libvdsm
......................................................................
Patch Set 3: (1 inline comment)
Also I got following error in generate 'setBalloonTarget':
generated.vala:7446.41-7446.46: error: Argument 2: Cannot convert from `uint64'
to `int64'
public void setBalloonTarget(uint64 target) throws VdsmError {
var object = new Json.Object();
var base_type = (BaseType) this;
object.set_object_member("__obj__", base_type.get_internal_object());
object.set_int_member("target", target);
var res = this.send_command("VM.setBalloonTarget", object);
response_check_error(res);
if (res.get_null_member("result"))
return;
return ;
}
....................................................
File vdsm_api/Makefile.am
Line 62: -X -fPIC -X -shared \
Line 63: --library=libvdsm \
Line 64: --gir=vdsm-0.1.gir \
Line 65: -o libvdsm.so \
Line 66: -H vdsm.h \
when I run:./autobuild.sh,
I will still get error:make[2]: *** No rule to make target `vdsm.h', needed by
`all-am'. Stop, until I add vdsm.h:Makefile
Line 67: --vapi=vdsm-0.1.vapi \
Line 68: $(NULL)
Line 69:
Line 70: generated.vala: generate.py vdsmapi-schema.json
--
To view, visit http://gerrit.ovirt.org/7516
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6bd34700b86aa84c7e289f02c0e9f2ac6fcba63
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
