Nir Soffer has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54900/2/lib/vdsm/storage/exception.py File lib/vdsm/storage/exception.py: Line 532: code = 313 Line 533: message = "Storage pool not connected" Line 534: Line 535: # Code 314 no longer used Line 536: # Code 315 no longer used > This is not very useful. How about: Also pep8 is not happy because it likes 2 empty lines between classes and comments (does not make sense but we cannot fight with pep8 gods). 20:47:29 ./lib/vdsm/storage/exception.py:538:1: E302 expected 2 blank lines, found 1 Line 537: Line 538: class StoragePoolAlreadyExists(StorageException): Line 539: code = 316 Line 540: message = "Error creating a storage pool - pool already exists" -- To view, visit https://gerrit.ovirt.org/54900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
