Freddy Rolland has posted comments on this change. Change subject: storage: move persistent to lib ......................................................................
Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/54582/1/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 34 Line 35 Line 36 Line 37 Line 38 > Import should be here Done Line 47: import blockVolume Line 48: import multipath Line 49: import resourceFactories Line 50: from resourceFactories import LVM_ACTIVATION_NAMESPACE Line 51: from vdsm.storage.persistent import PersistentDict, DictValidator > Move to vdsm.storage imports Done Line 52: import iscsi Line 53: from storage_mailbox import MAILBOX_SIZE Line 54: import resourceManager as rm Line 55: import mount https://gerrit.ovirt.org/#/c/54582/1/vdsm/storage/fileSD.py File vdsm/storage/fileSD.py: Line 33: import fileVolume Line 34: import misc Line 35: import outOfProcess as oop Line 36: from remoteFileHandler import Timeout Line 37: from vdsm.storage.persistent import PersistentDict, DictValidator > Move up under exception import Done Line 38: from vdsm import constants Line 39: from vdsm.utils import stripNewLines Line 40: from vdsm.storage.constants import LEASE_FILEEXT Line 41: from vdsm import supervdsm https://gerrit.ovirt.org/#/c/54582/1/vdsm/storage/sd.py File vdsm/storage/sd.py: Line 36: from vdsm import concurrent Line 37: from vdsm import constants Line 38: import clusterlock Line 39: import outOfProcess as oop Line 40: from vdsm.storage.persistent import unicodeEncoder, unicodeDecoder > Move up under exception import Done Line 41: import volume Line 42: Line 43: from vdsm.config import config Line 44: https://gerrit.ovirt.org/#/c/54582/1/vdsm/storage/spbackends.py File vdsm/storage/spbackends.py: Line 30: import sd Line 31: Line 32: from vdsm.storage.persistent import DictValidator Line 33: from vdsm.storage.persistent import unicodeDecoder Line 34: from vdsm.storage.persistent import unicodeEncoder > Move up under securable imports Done Line 35: from sp import LVER_INVALID Line 36: from sp import SPM_ACQUIRED Line 37: from sp import SPM_FREE Line 38: from sp import SPM_ID_FREE -- To view, visit https://gerrit.ovirt.org/54582 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I525423502e20aceca872dd26f5cb408e8e69d12d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
