Artyom Lukianov has posted comments on this change. Change subject: hooks:checkips: add checkips hook ......................................................................
Patch Set 5: (7 comments) https://gerrit.ovirt.org/#/c/54102/5/vdsm_hooks/checkips/README File vdsm_hooks/checkips/README: Line 24: orkCustomProperties='c > this would not work, as the second command would override the first. please Done Line 22: - Use the engine-config to append the proper custom property: Line 23: $ sudo engine-config -s UserDefinedNetworkCustomProperties='checkipv4=^[0-9\.a-fA-F]+$' Line 24: $ sudo engine-config -s UserDefinedNetworkCustomProperties='checkipv6=^[0-9\.a-fA-F\:]+$' Line 25: - Verify that the checkipv4 and checkipv6 custom properties was properly added: Line 26: $ sudo engine-config -g UserDefinedNetworkCustomProperties > the hook should be installed on all hosts, and its accompanying service sho Done Line 27: Line 28: Usage: Line 29: In the host setup network configuration window, choose edit assigned Line 30: logical network, select custom property checkipv4 or checkipv6 and enter VLAN IP or FQDN Line 30: N IP or FQD > short lines are cooler Done Line 31: 127.0.0.1,::1 > now it is a confusing example. how about 8.8.8.8 for ipv4 and 2001:4860:486 Done Line 28: Usage: Line 29: In the host setup network configuration window, choose edit assigned Line 30: logical network, select custom property checkipv4 or checkipv6 and enter VLAN IP or FQDN Line 31: that you want check for connectivity(example 127.0.0.1,::1). If IP does Line 32: not connective from host, it will drop host to non-operational state. > the semantic is not clear here. do we need BOTH to stay alive, or having on hm I thought we must guarantee connectivity to both IP's, IPV4 and also IPV6 so can you define what desired behaviour if a user set both custom properties(checkipv4 and checkipv6) 1) both IP's do not connective - host not operational 2) IPV4 is connective and IPV6 does not connective - ? 3) IPV4 not connective and IPV6 is connective - ? 4) both IP's connective - host operational https://gerrit.ovirt.org/#/c/54102/5/vdsm_hooks/checkips/checkips-vdsm.service.in File vdsm_hooks/checkips/checkips-vdsm.service.in: Line 1: [Unit] Line 2: Description=Service that ping given ips each 60 seconds > pardon, but I very much prefer vdsm-checkips name. we already have vdsm-net ok np, I just was not sure about naming convention, because we have: mom-vdsm Line 3: Line 4: [Service] Line 5: Type=simple Line 6: LimitCORE=infinity https://gerrit.ovirt.org/#/c/54102/5/vdsm_hooks/checkips/checkips_utils.py File vdsm_hooks/checkips/checkips_utils.py: Line 29: with open(file_path, 'a'): Line 30: os.utime(file_path, None) Line 31: Line 32: Line 33: def get_ping_attrs(net_attrs): > "attrs" is a very generic term, when all we have is the ping address and ad Done Line 34: ping_attrs = {} Line 35: if 'custom' in net_attrs: Line 36: if CHECKIPV4 in net_attrs['custom']: Line 37: ping_attrs['command'] = 'ping' -- To view, visit https://gerrit.ovirt.org/54102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <aluki...@redhat.com> Gerrit-Reviewer: Artyom Lukianov <aluki...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
