Francesco Romani has posted comments on this change. Change subject: osinfo: refactor package_versions function ......................................................................
Patch Set 5: Code-Review+1 (1 comment) looks fine https://gerrit.ovirt.org/#/c/54546/5/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line 129: if osname == OSName.RHEVH or osname == OSName.OVIRT: Line 130: version, release_name = _parse_node_version('/etc/default/version') Line 131: elif osname == OSName.DEBIAN: Line 132: version = linecache.getline('/etc/debian_version', 1).strip('\n') Line 133: release_name = '' # Debian just has a version entry this change is unneeded, but I don't mind this time. If you have to resubmit, please drop it. Line 134: else: Line 135: if osname == OSName.POWERKVM: Line 136: release_path = '/etc/ibm_powerkvm-release' Line 137: else: -- To view, visit https://gerrit.ovirt.org/54546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36e9a605bea5ec6b823eaca4d7669c5060122fcd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
