Martin Polednik has posted comments on this change. Change subject: hostdev: don't implicitly reattach devices ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54936/2//COMMIT_MSG Commit Message: Line 21: We can also assume that, on properly maintained : hosts, the devices are reserved for assignment and are not meant to be : used by the host at all. > hence, question: if we assume properly maintained host, shouldn't we skip s No, that is part of 'what we do for users'. We may at some point just let the user define a group of devices that will be used and detach them on startup, but it's unclear whether there are any more benefits to that approach. The idea behind this change is to do detach seamlessly, and only if the host is something like laptop used for testing allow user to reattach the device. Doing it automagically is dangerous. -- To view, visit https://gerrit.ovirt.org/54936 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1136292cb7e9d13a8202b1f5162299d2155e8036 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
