Martin Polednik has posted comments on this change. Change subject: virt: set correct permissions for hwrng device ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/54806/4/vdsm/supervdsm_api/udev.py File vdsm/supervdsm_api/udev.py: Line 70: _udevTrigger > we do this already for other subsystem, AFAIR it's as race-free as we could Let's assume it is not race free. Each function still creates it's file and triggers for given subsystem. In this model, it doesn't matter as long, as the file is owned by something that allows QEMU access (that is guaranteed by the fact that this functions is called and blocks. We don't care about future triggers. As for reverting the permissions, similar scenario occurs: the function will not be called before the VM is destroyed, and races between similar functions barely matter. I don't know how this exact case could be made more resilient. -- To view, visit https://gerrit.ovirt.org/54806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
