Dan Kenigsberg has posted comments on this change. Change subject: virt: Storage device legacy conf processing moved out of Vm ......................................................................
Patch Set 11: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/53489/11/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 522: I am sure that this function can be deleted now. living Engines (>=3.0) never pass hda/hdb. I am less certain about __removableDrives, but if Engine >=3.5 never send them, it is better to remove the code than to move it. -- To view, visit https://gerrit.ovirt.org/53489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36ccbeabf86ccb2db5f2135244e2699f43d7a495 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
