Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/54555/9/lib/vdsm/network/configurators/__init__.py File lib/vdsm/network/configurators/__init__.py: Line 216: wait_for_device > I think we had a problem with devices coming up, not about their creation/e The tests on F23 showed no need for waiting so I'll add a warning when a device doesn't exist and retest. https://gerrit.ovirt.org/#/c/54555/9/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1879: @permutations([[([4], [6])], Line 1880: [([6], [4])], Line 1881: [([4], [4, 6], [4])]]) Line 1882: @cleanupNet Line 1883: def testStaticNetworkConfig(self, ip_reconfigurations): > I find a lot of tests hard to understand, including this one (before your a Aha, maybe I understand now. Do you suggest to extract the inner function and just call it from different tests? That sounds okay. Line 1884: with dummyIf(1) as nics: Line 1885: nic, = nics Line 1886: IPv4 = dict(nic=nic, bootproto='none', ipaddr=IP_ADDRESS, Line 1887: netmask=IP_MASK, gateway=IP_GATEWAY) -- To view, visit https://gerrit.ovirt.org/54555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches