Pavel Zhukov has posted comments on this change.

Change subject: hooks: Add fcoe hook
......................................................................


Patch Set 10:

(3 comments)

https://gerrit.ovirt.org/#/c/55029/10/vdsm.spec.in
File vdsm.spec.in:

Line 622: VDSM hook used for applying IPv6 configuration through custom network
Line 623: properties
Line 624: 
Line 625: %package hook-fcoe
Line 626: Summary:        Hook for enable fcoe support
> for -> to
fixed
Line 627: BuildArch:      noarch
Line 628: Requires:       %{name} = %{version}-%{release}
Line 629: Requires:       fcoe-utils
Line 630: 


Line 625: %package hook-fcoe
Line 626: Summary:        Hook for enable fcoe support
Line 627: BuildArch:      noarch
Line 628: Requires:       %{name} = %{version}-%{release}
Line 629: Requires:       fcoe-utils
> What about lldpad?
fcoe-utils depends on it
Line 630: 
Line 631: %description hook-fcoe
Line 632: %{summary}
Line 633: 


Line 627: BuildArch:      noarch
Line 628: Requires:       %{name} = %{version}-%{release}
Line 629: Requires:       fcoe-utils
Line 630: 
Line 631: %description hook-fcoe
> thin description...
fixed
Line 632: %{summary}
Line 633: 
Line 634: %if 0%{?with_gluster_mgmt}
Line 635: %package gluster


-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Zhukov <pzhu...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to