Piotr Kliczewski has posted comments on this change. Change subject: hostdev: add support for hotunplug ......................................................................
Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42747/6/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 7743: hostdevHotunplug Why do we need 2 times vmId? One is needed to construct VM object. Is the second vmId different form params parameter? Why not to reuse vmId passed during construction of VM object. -- To view, visit https://gerrit.ovirt.org/42747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If36f7da8f018615b76a1a8779ff15b890a823db8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
