Edward Haas has posted comments on this change. Change subject: netinfo: cache: allow root-requiring changes in get() ......................................................................
Patch Set 2: Code-Review-1 I imagined it a bit different, let me know what you think: From getCapabilities(), after the regular caps.get(), call supervdsm.getProxy().supercaps_network() and complement the needed. supercaps_network() will build/use ovs_netinfo. This way, testing will be simple and we will not have calls between non-root to root from inside the modules. The other option, is to be consistent and use supervdsm for all network caps, but that will increase root usage which is bad. Dan is against it. -- To view, visit https://gerrit.ovirt.org/55073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84c6e8aa5a3820638a26aab6d112f0285b1fbd8c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
