Nir Soffer has posted comments on this change. Change subject: fileUtils: Warn about callers of fileUtils.createdir() ......................................................................
Patch Set 5: Here is a log when warnings are enabled: Note that we get a warning for the code calling this function - this code should be inspected and probably fixed not to create unneeded directories. # xzgrep 'UserWarning: Using existing direcotory:' /var/log/vdsm/vdsm.log.1.xz MainThread::WARNING::2016-03-22 20:19:04,667::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/hsm.py:344: UserWarning: Using existing direcotory: /rhev/data-center/mnt jsonrpc.Executor/4::WARNING::2016-03-22 20:19:42,160::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/sp.py:1267: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/dom_md jsonrpc.Executor/4::WARNING::2016-03-22 20:19:42,160::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/sp.py:1268: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/images jsonrpc.Executor/4::WARNING::2016-03-22 20:19:42,172::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:691: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/images jsonrpc.Executor/4::WARNING::2016-03-22 20:19:42,172::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:695: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/dom_md Thread-45::WARNING::2016-03-22 20:19:42,208::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:691: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/images Thread-45::WARNING::2016-03-22 20:19:42,208::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:695: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/dom_md Thread-61::WARNING::2016-03-22 20:19:42,756::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:691: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/images Thread-61::WARNING::2016-03-22 20:19:42,757::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:695: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/dom_md jsonrpc.Executor/1::WARNING::2016-03-22 20:19:49,638::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/sp.py:1237: UserWarning: Using existing direcotory: /rhev/data-center/591475db-6fa9-455d-9c05-7f6e30fb06d5 jsonrpc.Executor/1::WARNING::2016-03-22 20:19:50,316::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/sp.py:1267: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/dom_md jsonrpc.Executor/1::WARNING::2016-03-22 20:19:50,316::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/sp.py:1268: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/images jsonrpc.Executor/1::WARNING::2016-03-22 20:19:50,321::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:691: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/images jsonrpc.Executor/1::WARNING::2016-03-22 20:19:50,322::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:695: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/dom_md 8a693e96-0e89-4a5d-a3b2-093e18988e43::WARNING::2016-03-22 20:20:03,444::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:691: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/images 8a693e96-0e89-4a5d-a3b2-093e18988e43::WARNING::2016-03-22 20:20:03,444::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:695: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/dom_md 8a693e96-0e89-4a5d-a3b2-093e18988e43::WARNING::2016-03-22 20:20:04,224::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:1215: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/master -- To view, visit https://gerrit.ovirt.org/37003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c3e7e21367eb690d0c7a6c6f79c515b18a9fff0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
