Antoni Segura Puimedon has posted comments on this change. Change subject: Keep nics up after network ops. ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/configNetwork.py Line 1203: # Take down all bond's NICs. Line 1204: for nic in _netinfo.getNicsForBonding(bond): Line 1205: ifdown(nic) Line 1206: configWriter.removeNic(nic) Line 1207: ifup(nic) Agreed! Good catch ;) Line 1208: Line 1209: # Note! In case we have bridge up and connected to the bond Line 1210: # we will get error in log: Line 1211: # (ifdown) bridge XXX is still up; can't delete it -- To view, visit http://gerrit.ovirt.org/8443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bc0e6e5c7bc92c8ff3aa007572ee461ea69c366 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
