Martin Polednik has posted comments on this change. Change subject: hostdev: expose 'driver' attribute ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/55044/3/tests/devices/data/pci_0000_00_1a_0.xml File tests/devices/data/pci_0000_00_1a_0.xml: Line 1: <device> Line 2: <name>pci_0000_00_1a_0</name> Line 3: <path>/sys/devices/pci0000:00/0000:00:1a.0</path> Line 4: <parent>computer</parent> > thanks for the negative test! Could you please just remind me how this is t hostdevTests - testGetDevicesFromLibvirt calls hostdev._get_devices_from_libvirt where the libvirt connection is faked with our hostdev-aware fake libvirt that, instead of looking up the name in libvirt cache, accesses the fs. Line 5: <capability type='pci'> Line 6: <domain>0</domain> Line 7: <bus>0</bus> Line 8: <slot>26</slot> -- To view, visit https://gerrit.ovirt.org/55044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81463100dd07a2bc4fb241f89581db2060b8982e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
