Edward Haas has posted comments on this change. Change subject: net: Adding the netswitch module ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/55131/1/lib/vdsm/network/api.py File lib/vdsm/network/api.py: Line 248: in_rollback = options.get('_inRollback', False) Line 249: with _rollback(): Line 250: for switch in netswitch.switches(): Line 251: netswitch.setup(switch, networks, bondings, in_rollback) Line 252: _check_connectivity(networks, bondings, options) This does not work well.. Connectivity check needs to be agnostic to what we setup (switch, ip, other stuff), so it fits well at this layer. However, the switch inner contexmanager needs to 'capture' its exception and handle it. Line 253: Line 254: Line 255: def setSafeNetworkConfig(): Line 256: """Declare current network configuration as 'safe'""" -- To view, visit https://gerrit.ovirt.org/55131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I869e634e9f97cf279d4df83fca2b8f8d73bcea47 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
