Igor Lvovsky has posted comments on this change.
Change subject: [WIP] Don't fail silently when ifup fails.
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File vdsm/configNetwork.py
Line 65: "Bring up an interface"
Line 66: def _ifup(netIf, toCall=None):
Line 67: rc, out, err = execCmd([constants.EXT_IFUP, netIf], raw=False)
Line 68:
Line 69: if rc != 0:
It's may be problematic now, since in your other patch you keep all free NICs
as UP.
The additional up will always back with rc=1 and we will raise exception.
I am not sure whether this correct, but it definitely different behaviour.
Line 70: # In /etc/sysconfig/network-scripts/ifup* the last line
usually
Line 71: # contains the error reason.
Line 72: raise ConfigNetworkError(ne.ERR_FAILED_IFUP, out[-1])
Line 73: elif toCall is not None:
Line 992: libvirtNetworkCreation)
Line 993:
Line 994: # add libvirt network
Line 995: if not async:
Line 996: libvirtNetworkCreation()
why this dependency from async?
I still don't like this, looks like big overhead to me.
Line 997:
Line 998:
Line 999: def assertBridgeClean(bridge, vlan, bonding, nics):
Line 1000: brifs = os.listdir('/sys/class/net/%s/brif/' % bridge)
....................................................
File vdsm/neterrors.py
Line 26: ERR_BAD_BONDING = 25
Line 27: ERR_BAD_VLAN = 26
Line 28: ERR_BAD_BRIDGE = 27
Line 29: ERR_USED_BRIDGE = 28
Line 30: ERR_FAILED_IFUP = 30
what happened with 29 :)
--
To view, visit http://gerrit.ovirt.org/8415
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
