Ayal Baron has posted comments on this change.
Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf
......................................................................
Patch Set 9: I would prefer that you didn't submit this
(4 inline comments)
....................................................
Commit Message
Line 7: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf
Line 8:
Line 9: The nfs_mount_options configuration setting in vdsm.conf was ignored.
Line 10:
Line 11: If the engine doesn't pass any mount options, and nfs_mount_options are
Now that you've introduced the patch to make V3 the default, does engine not
pass V3 by default? (effectively always overriding vdsm.conf options?)
Line 12: present (and not the defaults), then use the options from the config
Line 13: file. Otherwise, use whatever the engine passes and/or defaults as was
Line 14: done previously.
Line 15:
....................................................
File vdsm/storage/hsm.py
Line 2143:
Line 2144: def _getNFSDomainToConInfoMap(self):
Line 2145: dirConMap = {} # directory -> connectionInfo
Line 2146: for conInfo in [conInfo for conInfo in self._connectionList
Line 2147: if isinstance(conInfo,
storageServer.NFSConnection)]:
this should be determined once when connecting, not every time
getStoragePoolInfo is run (every 10s).
Value for getStoragePoolInfo should basically be static.
Line 2148: path = conInfo.mountPath
Line 2149: if path is not None:
Line 2150: dirConMap[path] = conInfo
Line 2151:
Line 2149: if path is not None:
Line 2150: dirConMap[path] = conInfo
Line 2151:
Line 2152: sdConMap = {} # sdUUID -> connectionInfo
Line 2153: for sdUUID, domDir in fileSD.scanDomains():
running scanDomains every 10s is a catastrophe and totally redundant, as we
already know what to check when connecting to the specific nfs server *and*
only need to do so if the non default values in vdsm.conf are used...
Line 2154: try:
Line 2155: dom = sdCache.produce(sdUUID=sdUUID)
Line 2156: if dom.getStorageType() == sd.NFS_DOMAIN:
Line 2157: domMount = domDir[:(domDir.rfind("/"))] # strip
off UUID
Line 2151:
Line 2152: sdConMap = {} # sdUUID -> connectionInfo
Line 2153: for sdUUID, domDir in fileSD.scanDomains():
Line 2154: try:
Line 2155: dom = sdCache.produce(sdUUID=sdUUID)
producing a domain is a potentially heavy operation which can also hang in case
of nfs problems and you already know if your mount is nfs or not when
connecting.
Seeing as the configuration is not limited to a specific domain but rather to
vdsm in general (any nfs domain would get these params) there is no need for
all of this.
Line 2156: if dom.getStorageType() == sd.NFS_DOMAIN:
Line 2157: domMount = domDir[:(domDir.rfind("/"))] # strip
off UUID
Line 2158: if domMount in dirConMap:
Line 2159: sdConMap[sdUUID] = dirConMap[domMount]
--
To view, visit http://gerrit.ovirt.org/5368
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
